KAFKA-14375: Remove use of "authorizer-properties" from EndToEndAuthorizerTest#12843
Merged
omkreddy merged 5 commits intoapache:trunkfrom Nov 17, 2022
Merged
Conversation
This removes use of a depricated feature and instead has all ACL calls going through the brokers. This work is preliminary work needed before I can make them run in KRAFT mode.
soarez
reviewed
Nov 14, 2022
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/PlaintextEndToEndAuthorizationTest.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Sorry about the extra space, bad camel case and spelling. |
…erties" from EndToEndAuthorizerTest. Delegation tests still talk directly to ZK and Delegation Tokens have not been added to work under KRAFT so I'm holding off changing these tests to talk to brokers instead of ZK for initial setup.
omkreddy
reviewed
Nov 15, 2022
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
Show resolved
Hide resolved
Contributor
|
looks like we also need to update |
Contributor
Author
|
The test |
Contributor
Author
|
I see some failed tests that seem to be flaky tests. What do we do here? |
omkreddy
changed the title
if the brokers are set as superusers.
omkreddy
reviewed
Nov 16, 2022
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/SslEndToEndAuthorizationTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/SslEndToEndAuthorizationTest.scala
Outdated
Show resolved
Hide resolved
Remove unneeded ACL defines in EndToEndAuthorizationTest.scala Define a superuserCn in SslEndToEndAuthorizationTest.scala
Contributor
Author
|
I have manually tested all the failed tests from the checks and they all pass fine locally. |
omkreddy
approved these changes
Nov 17, 2022
Contributor
omkreddy
left a comment
omkreddy
left a comment
There was a problem hiding this comment.
@pprovenzano Thanks for the PR. LGTM
3 tasks
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…rizerTest (apache#12843) - This removes use of a deprecated feature and instead has all ACL calls going through the brokers. This work is preliminary work needed before I can make them run in KRAFT mode. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, Igor Soarez <soarez@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes use of a deprecated feature and instead has all ACL calls going through the brokers. This work is preliminary work needed before I can make them run in KRAFT mode.
https://issues.apache.org/jira/browse/KAFKA-14375
Committer Checklist (excluded from commit message)